优化代码

framework/src/main/java/cn/lili/cache/limit/interceptor/LimitInterceptor.java

@@ -1,7 +1,7 @@
 package cn.lili.cache.limit.interceptor;
 
-import cn.lili.cache.limit.enums.LimitTypeEnums;
 import cn.lili.cache.limit.annotation.LimitPoint;
+import cn.lili.cache.limit.enums.LimitTypeEnums;
 import cn.lili.common.enums.ResultCode;
 import cn.lili.common.exception.ServiceException;
 import cn.lili.common.utils.IpUtils;
@@ -17,7 +17,6 @@ import org.springframework.data.redis.core.script.DefaultRedisScript;
 import org.springframework.web.context.request.RequestContextHolder;
 import org.springframework.web.context.request.ServletRequestAttributes;
 
-import javax.servlet.http.HttpServletRequest;
 import java.io.Serializable;
 
 /**

framework/src/main/java/cn/lili/common/aop/annotation/PreventDuplicateSubmissions.java

@@ -1,7 +1,6 @@
 package cn.lili.common.aop.annotation;
 
 import java.lang.annotation.*;
-import java.util.concurrent.TimeUnit;
 
 /**
  * 防止重复提交注解

framework/src/main/java/cn/lili/common/aop/interceptor/DemoInterceptor.java

@@ -26,7 +26,7 @@ public class DemoInterceptor {
 
     @Before("@annotation(demoSite)")
     public void doAfter(DemoSite demoSite) {
-        if (systemSettingProperties.getIsDemoSite()) {
+        if (Boolean.TRUE.equals(systemSettingProperties.getIsDemoSite())) {
             throw new ServiceException(ResultCode.DEMO_SITE_EXCEPTION);
         }
     }

framework/src/main/java/cn/lili/common/utils/SnowflakeInitiator.java

@@ -1,15 +1,11 @@
 package cn.lili.common.utils;
 
 import cn.lili.cache.Cache;
-import com.alibaba.fastjson.JSON;
-import lombok.AllArgsConstructor;
-import lombok.Data;
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.stereotype.Component;
 
 import javax.annotation.PostConstruct;
-import java.util.concurrent.TimeUnit;
 
 /**
  * SnowflakeInitiator
@@ -25,7 +21,7 @@ public class SnowflakeInitiator {
     /**
      * 缓存前缀
      */
-    private static String KEY = "{Snowflake}";
+    private static final String KEY = "{Snowflake}";
 
     @Autowired
     private Cache cache;

framework/src/main/java/cn/lili/modules/member/serviceimpl/MemberEvaluationServiceImpl.java

@@ -106,13 +106,14 @@ public class MemberEvaluationServiceImpl extends ServiceImpl<MemberEvaluationMap
     }
 
     @Override
+    @Transactional(rollbackFor = Exception.class)
     public MemberEvaluationDTO addMemberEvaluation(MemberEvaluationDTO memberEvaluationDTO, Boolean isSelf) {
         //获取子订单信息
         OrderItem orderItem = orderItemService.getBySn(memberEvaluationDTO.getOrderItemSn());
         //获取订单信息
         Order order = orderService.getBySn(orderItem.getOrderSn());
         //检测是否可以添加会员评价
-        if (isSelf) {
+        if (Boolean.TRUE.equals(isSelf)) {
             checkMemberEvaluation(orderItem, order);
         }
         //获取用户信息

framework/src/main/java/cn/lili/modules/member/serviceimpl/MemberSignServiceImpl.java

@@ -2,34 +2,30 @@ package cn.lili.modules.member.serviceimpl;
 
 import cn.lili.common.enums.ResultCode;
 import cn.lili.common.exception.ServiceException;
-import cn.lili.modules.member.entity.enums.PointTypeEnum;
+import cn.lili.common.properties.RocketmqCustomProperties;
-import cn.lili.modules.system.entity.dto.PointSettingItem;
-import cn.lili.rocketmq.RocketmqSendCallbackBuilder;
-import cn.lili.rocketmq.tags.MemberTagsEnum;
 import cn.lili.common.security.AuthUser;
 import cn.lili.common.security.context.UserContext;
 import cn.lili.common.utils.CurrencyUtil;
 import cn.lili.common.utils.DateUtil;
-import cn.lili.common.utils.StringUtils;
-import cn.lili.common.properties.RocketmqCustomProperties;
 import cn.lili.modules.member.entity.dos.MemberSign;
+import cn.lili.modules.member.entity.enums.PointTypeEnum;
 import cn.lili.modules.member.mapper.MemberSignMapper;
 import cn.lili.modules.member.service.MemberService;
 import cn.lili.modules.member.service.MemberSignService;
 import cn.lili.modules.system.entity.dos.Setting;
 import cn.lili.modules.system.entity.dto.PointSetting;
+import cn.lili.modules.system.entity.dto.PointSettingItem;
 import cn.lili.modules.system.entity.enums.SettingEnum;
 import cn.lili.modules.system.service.SettingService;
-import com.baomidou.mybatisplus.core.conditions.query.QueryWrapper;
+import cn.lili.rocketmq.RocketmqSendCallbackBuilder;
+import cn.lili.rocketmq.tags.MemberTagsEnum;
 import com.baomidou.mybatisplus.extension.service.impl.ServiceImpl;
 import com.google.gson.Gson;
 import org.apache.rocketmq.spring.core.RocketMQTemplate;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.stereotype.Service;
 
-import java.util.Date;
 import java.util.List;
-import java.util.Map;
 
 /**
  * 会员签到业务层实现
@@ -74,7 +70,7 @@ public class MemberSignServiceImpl extends ServiceImpl<MemberSignMapper, MemberS
             memberSign.setMemberId(authUser.getId());
             memberSign.setMemberName(authUser.getUsername());
             //如果size大于0 说明昨天已经签到过，获取昨天的签到数，反之新签到
-            if (signs.size() > 0) {
+            if (!signs.isEmpty()) {
                 //截止目前为止 签到总天数 不带今天
                 Integer signDay = signs.get(0).getSignDay();
                 memberSign.setSignDay(CurrencyUtil.add(signDay, 1).intValue());

framework/src/main/java/cn/lili/modules/promotion/serviceimpl/MemberCouponServiceImpl.java

@@ -82,6 +82,7 @@ public class MemberCouponServiceImpl extends ServiceImpl<MemberCouponMapper, Mem
      */
     @Override
     @CacheEvict(key = "#memberId")
+    @Transactional(rollbackFor = Exception.class)
     public void receiveBuyerCoupon(String couponId, String memberId, String memberName) {
         Coupon coupon = couponService.getById(couponId);
         if (coupon != null && !CouponGetEnum.FREE.name().equals(coupon.getGetType())) {
@@ -94,6 +95,7 @@ public class MemberCouponServiceImpl extends ServiceImpl<MemberCouponMapper, Mem
 
     @Override
     @CacheEvict(key = "#memberId")
+    @Transactional(rollbackFor = Exception.class)
     public void receiveCoupon(String couponId, String memberId, String memberName) {
         Coupon coupon = couponService.getById(couponId);
         if (coupon != null) {
@@ -219,6 +221,7 @@ public class MemberCouponServiceImpl extends ServiceImpl<MemberCouponMapper, Mem
 
     @Override
     @CacheEvict(key = "#memberId")
+    @Transactional(rollbackFor = Exception.class)
     public void used(String memberId, List<String> ids) {
         if (ids != null && !ids.isEmpty()) {
             List<MemberCoupon> memberCoupons = this.listByIds(ids);
@@ -247,6 +250,7 @@ public class MemberCouponServiceImpl extends ServiceImpl<MemberCouponMapper, Mem
      */
     @Override
     @CacheEvict(key = "#memberId")
+    @Transactional(rollbackFor = Exception.class)
     public void cancellation(String memberId, String id) {
         LambdaUpdateWrapper<MemberCoupon> updateWrapper = new LambdaUpdateWrapper<>();
         updateWrapper.eq(MemberCoupon::getId, id);
@@ -260,6 +264,7 @@ public class MemberCouponServiceImpl extends ServiceImpl<MemberCouponMapper, Mem
      * @param couponIds 优惠券id集合
      */
     @Override
+    @Transactional(rollbackFor = Exception.class)
     public void closeMemberCoupon(List<String> couponIds) {
         LambdaUpdateWrapper<MemberCoupon> memberCouponLambdaUpdateWrapper = new LambdaUpdateWrapper<MemberCoupon>()
                 .in(MemberCoupon::getCouponId, couponIds)

framework/src/main/java/cn/lili/modules/system/entity/dto/PointSettingItem.java

@@ -3,6 +3,8 @@ package cn.lili.modules.system.entity.dto;
 import io.swagger.annotations.ApiModelProperty;
 import lombok.Data;
 
+import java.io.Serializable;
+
 /**
  * 积分签到设置
  *
@@ -10,7 +12,7 @@ import lombok.Data;
  * @since 2021-02-26 11:48
  */
 @Data
-public class PointSettingItem implements Comparable<PointSettingItem> {
+public class PointSettingItem implements Comparable<PointSettingItem>, Serializable {
 
 
     @ApiModelProperty(value = "签到天数")
@@ -21,7 +23,7 @@ public class PointSettingItem implements Comparable<PointSettingItem> {
     private Integer point;
 
     public Integer getPoint() {
-        if (point != null || point < 0) {
+        if (point == null || point < 0) {
             return 0;
         }
         return point;