refactor:代码逻辑可能出现问题,重构代码执行顺序
This commit is contained in:
parent
11778a632a
commit
ceb61318f0
@ -148,11 +148,12 @@ public class ClerkServiceImpl extends ServiceImpl<ClerkMapper, Clerk> implements
|
|||||||
@Override
|
@Override
|
||||||
public Clerk updateClerk(ClerkEditDTO clerkEditDTO) {
|
public Clerk updateClerk(ClerkEditDTO clerkEditDTO) {
|
||||||
Clerk clerk = this.getById(clerkEditDTO.getId());
|
Clerk clerk = this.getById(clerkEditDTO.getId());
|
||||||
|
if (clerk != null) {
|
||||||
|
//编辑店主限制
|
||||||
if(clerk.getShopkeeper()){
|
if(clerk.getShopkeeper()){
|
||||||
throw new ServiceException(ResultCode.CANT_EDIT_CLERK_SHOPKEEPER);
|
throw new ServiceException(ResultCode.CANT_EDIT_CLERK_SHOPKEEPER);
|
||||||
}
|
}
|
||||||
|
|
||||||
if (clerk != null) {
|
|
||||||
//校验当前店员是否是当前店铺的
|
//校验当前店员是否是当前店铺的
|
||||||
if (!clerk.getStoreId().equals(UserContext.getCurrentUser().getStoreId())) {
|
if (!clerk.getStoreId().equals(UserContext.getCurrentUser().getStoreId())) {
|
||||||
throw new ServiceException(ResultCode.USER_AUTHORITY_ERROR);
|
throw new ServiceException(ResultCode.USER_AUTHORITY_ERROR);
|
||||||
|
Loading…
x
Reference in New Issue
Block a user